From 31af041cce507c5ab2430a493880b3d1741c7ff4 Mon Sep 17 00:00:00 2001 From: Per Date: Sun, 29 Sep 2019 15:40:48 +0200 Subject: [PATCH] polishing the Notes.md --- Notes.md | 39 ++++--- lockopt.asm | 303 ++++++++++++++++++++++++---------------------------- 2 files changed, 156 insertions(+), 186 deletions(-) diff --git a/Notes.md b/Notes.md index 7a6220c186..c7f881d361 100644 --- a/Notes.md +++ b/Notes.md @@ -148,28 +148,25 @@ Overall, using this approach, we don't need a trampoline (`run`). We reduce the The `examples/lockopt.rs` shows that locks are effectively optimized out. ``` asm -00000132 : - 132: b510 push {r4, lr} - 134: f000 f893 bl 25e <__basepri_r> - 138: 4604 mov r4, r0 - 13a: 20a0 movs r0, #160 ; 0xa0 - 13c: f000 f892 bl 264 <__basepri_w> - 140: f240 0000 movw r0, #0 - 144: f2c2 0000 movt r0, #8192 ; 0x2000 - 148: 6801 ldr r1, [r0, #0] - 14a: 3101 adds r1, #1 - 14c: 6001 str r1, [r0, #0] - 14e: 4620 mov r0, r4 - 150: e8bd 4010 ldmia.w sp!, {r4, lr} - 154: f000 b886 b.w 264 <__basepri_w> +00000128 : + 128: 21a0 movs r1, #160 ; 0xa0 + 12a: f3ef 8011 mrs r0, BASEPRI + 12e: f381 8811 msr BASEPRI, r1 + 132: f240 0100 movw r1, #0 + 136: f2c2 0100 movt r1, #8192 ; 0x2000 + 13a: 680a ldr r2, [r1, #0] + 13c: 3201 adds r2, #1 + 13e: 600a str r2, [r1, #0] + 140: f380 8811 msr BASEPRI, r0 + 144: 4770 bx lr -00000158 : - 158: f240 0000 movw r0, #0 - 15c: f2c2 0000 movt r0, #8192 ; 0x2000 - 160: 6801 ldr r1, [r0, #0] - 162: 3102 adds r1, #2 - 164: 6001 str r1, [r0, #0] - 166: 4770 bx lr +00000146 : + 146: f240 0000 movw r0, #0 + 14a: f2c2 0000 movt r0, #8192 ; 0x2000 + 14e: 6801 ldr r1, [r0, #0] + 150: 3102 adds r1, #2 + 152: 6001 str r1, [r0, #0] + 154: 4770 bx lr ``` GPIOB/C are sharing a resource (C higher prio). Notice, there is no BASEPRI manipulation at all. diff --git a/lockopt.asm b/lockopt.asm index dadbd91079..5d169ea8bb 100644 --- a/lockopt.asm +++ b/lockopt.asm @@ -5,188 +5,161 @@ target/thumbv7m-none-eabi/release/examples/lockopt: file format elf32-little Disassembly of section .text: 000000f0 : - f0: b510 push {r4, lr} - f2: f000 f8b4 bl 25e <__basepri_r> - f6: 4604 mov r4, r0 - f8: 20a0 movs r0, #160 ; 0xa0 - fa: f000 f8b3 bl 264 <__basepri_w> - fe: f240 0000 movw r0, #0 - 102: f2c2 0000 movt r0, #8192 ; 0x2000 - 106: 6801 ldr r1, [r0, #0] - 108: 3101 adds r1, #1 - 10a: 6001 str r1, [r0, #0] - 10c: f24e 2000 movw r0, #57856 ; 0xe200 - 110: 2102 movs r1, #2 - 112: f2ce 0000 movt r0, #57344 ; 0xe000 - 116: 6001 str r1, [r0, #0] - 118: 2104 movs r1, #4 - 11a: 6001 str r1, [r0, #0] - 11c: 4620 mov r0, r4 - 11e: f000 f8a1 bl 264 <__basepri_w> - 122: 2126 movs r1, #38 ; 0x26 - 124: 2018 movs r0, #24 - 126: f2c0 0102 movt r1, #2 - 12a: e8bd 4010 ldmia.w sp!, {r4, lr} - 12e: f000 b88e b.w 24e <__syscall> + f0: 21a0 movs r1, #160 ; 0xa0 + f2: f3ef 8011 mrs r0, BASEPRI + f6: f381 8811 msr BASEPRI, r1 + fa: f240 0100 movw r1, #0 + fe: f2c2 0100 movt r1, #8192 ; 0x2000 + 102: 680a ldr r2, [r1, #0] + 104: 3201 adds r2, #1 + 106: 600a str r2, [r1, #0] + 108: f24e 2100 movw r1, #57856 ; 0xe200 + 10c: 2202 movs r2, #2 + 10e: f2ce 0100 movt r1, #57344 ; 0xe000 + 112: 600a str r2, [r1, #0] + 114: 2204 movs r2, #4 + 116: 600a str r2, [r1, #0] + 118: 2126 movs r1, #38 ; 0x26 + 11a: f380 8811 msr BASEPRI, r0 + 11e: f2c0 0102 movt r1, #2 + 122: 2018 movs r0, #24 + 124: f000 b887 b.w 236 <__syscall> -00000132 : - 132: b510 push {r4, lr} - 134: f000 f893 bl 25e <__basepri_r> - 138: 4604 mov r4, r0 - 13a: 20a0 movs r0, #160 ; 0xa0 - 13c: f000 f892 bl 264 <__basepri_w> - 140: f240 0000 movw r0, #0 - 144: f2c2 0000 movt r0, #8192 ; 0x2000 - 148: 6801 ldr r1, [r0, #0] - 14a: 3101 adds r1, #1 - 14c: 6001 str r1, [r0, #0] - 14e: 4620 mov r0, r4 - 150: e8bd 4010 ldmia.w sp!, {r4, lr} - 154: f000 b886 b.w 264 <__basepri_w> +00000128 : + 128: 21a0 movs r1, #160 ; 0xa0 + 12a: f3ef 8011 mrs r0, BASEPRI + 12e: f381 8811 msr BASEPRI, r1 + 132: f240 0100 movw r1, #0 + 136: f2c2 0100 movt r1, #8192 ; 0x2000 + 13a: 680a ldr r2, [r1, #0] + 13c: 3201 adds r2, #1 + 13e: 600a str r2, [r1, #0] + 140: f380 8811 msr BASEPRI, r0 + 144: 4770 bx lr -00000158 : - 158: f240 0000 movw r0, #0 - 15c: f2c2 0000 movt r0, #8192 ; 0x2000 - 160: 6801 ldr r1, [r0, #0] - 162: 3102 adds r1, #2 - 164: 6001 str r1, [r0, #0] - 166: 4770 bx lr +00000146 : + 146: f240 0000 movw r0, #0 + 14a: f2c2 0000 movt r0, #8192 ; 0x2000 + 14e: 6801 ldr r1, [r0, #0] + 150: 3102 adds r1, #2 + 152: 6001 str r1, [r0, #0] + 154: 4770 bx lr -00000168
: - 168: f000 f873 bl 252 <__cpsid> - 16c: f24e 1000 movw r0, #57600 ; 0xe100 - 170: f24e 4201 movw r2, #58369 ; 0xe401 - 174: f2ce 0000 movt r0, #57344 ; 0xe000 - 178: 21e0 movs r1, #224 ; 0xe0 - 17a: f880 1300 strb.w r1, [r0, #768] ; 0x300 - 17e: 2101 movs r1, #1 - 180: f2ce 0200 movt r2, #57344 ; 0xe000 - 184: 23c0 movs r3, #192 ; 0xc0 - 186: 6001 str r1, [r0, #0] - 188: 7013 strb r3, [r2, #0] - 18a: 2302 movs r3, #2 - 18c: 6003 str r3, [r0, #0] - 18e: 23a0 movs r3, #160 ; 0xa0 - 190: 7053 strb r3, [r2, #1] - 192: 2204 movs r2, #4 - 194: 6002 str r2, [r0, #0] - 196: f64e 5210 movw r2, #60688 ; 0xed10 - 19a: f2ce 0200 movt r2, #57344 ; 0xe000 - 19e: 6813 ldr r3, [r2, #0] - 1a0: f043 0302 orr.w r3, r3, #2 - 1a4: 6013 str r3, [r2, #0] - 1a6: f8c0 1100 str.w r1, [r0, #256] ; 0x100 - 1aa: f000 f854 bl 256 <__cpsie> - 1ae: f000 f854 bl 25a <__wfi> - 1b2: e7fc b.n 1ae +00000156
: + 156: f24e 1000 movw r0, #57600 ; 0xe100 + 15a: f24e 4201 movw r2, #58369 ; 0xe401 + 15e: f2ce 0000 movt r0, #57344 ; 0xe000 + 162: 21e0 movs r1, #224 ; 0xe0 + 164: b672 cpsid i + 166: f880 1300 strb.w r1, [r0, #768] ; 0x300 + 16a: 2101 movs r1, #1 + 16c: f2ce 0200 movt r2, #57344 ; 0xe000 + 170: 23c0 movs r3, #192 ; 0xc0 + 172: 6001 str r1, [r0, #0] + 174: 7013 strb r3, [r2, #0] + 176: 2302 movs r3, #2 + 178: 6003 str r3, [r0, #0] + 17a: 23a0 movs r3, #160 ; 0xa0 + 17c: 7053 strb r3, [r2, #1] + 17e: 2204 movs r2, #4 + 180: 6002 str r2, [r0, #0] + 182: f64e 5210 movw r2, #60688 ; 0xed10 + 186: f2ce 0200 movt r2, #57344 ; 0xe000 + 18a: 6813 ldr r3, [r2, #0] + 18c: f043 0302 orr.w r3, r3, #2 + 190: 6013 str r3, [r2, #0] + 192: f8c0 1100 str.w r1, [r0, #256] ; 0x100 + 196: b662 cpsie i + 198: bf30 wfi + 19a: e7fd b.n 198 -000001b4 : - 1b4: f000 f84a bl 24c - 1b8: f240 0004 movw r0, #4 - 1bc: f240 0100 movw r1, #0 - 1c0: f2c2 0000 movt r0, #8192 ; 0x2000 - 1c4: f2c2 0100 movt r1, #8192 ; 0x2000 - 1c8: 4281 cmp r1, r0 - 1ca: d214 bcs.n 1f6 - 1cc: f240 0100 movw r1, #0 - 1d0: 2200 movs r2, #0 - 1d2: f2c2 0100 movt r1, #8192 ; 0x2000 +0000019c : + 19c: f000 f84a bl 234 + 1a0: f240 0004 movw r0, #4 + 1a4: f240 0100 movw r1, #0 + 1a8: f2c2 0000 movt r0, #8192 ; 0x2000 + 1ac: f2c2 0100 movt r1, #8192 ; 0x2000 + 1b0: 4281 cmp r1, r0 + 1b2: d214 bcs.n 1de + 1b4: f240 0100 movw r1, #0 + 1b8: 2200 movs r2, #0 + 1ba: f2c2 0100 movt r1, #8192 ; 0x2000 + 1be: f841 2b04 str.w r2, [r1], #4 + 1c2: 4281 cmp r1, r0 + 1c4: bf3c itt cc + 1c6: f841 2b04 strcc.w r2, [r1], #4 + 1ca: 4281 cmpcc r1, r0 + 1cc: d207 bcs.n 1de + 1ce: f841 2b04 str.w r2, [r1], #4 + 1d2: 4281 cmp r1, r0 + 1d4: d203 bcs.n 1de 1d6: f841 2b04 str.w r2, [r1], #4 1da: 4281 cmp r1, r0 - 1dc: bf3c itt cc - 1de: f841 2b04 strcc.w r2, [r1], #4 - 1e2: 4281 cmpcc r1, r0 - 1e4: d207 bcs.n 1f6 - 1e6: f841 2b04 str.w r2, [r1], #4 - 1ea: 4281 cmp r1, r0 - 1ec: d203 bcs.n 1f6 - 1ee: f841 2b04 str.w r2, [r1], #4 - 1f2: 4281 cmp r1, r0 - 1f4: d3ef bcc.n 1d6 - 1f6: f240 0000 movw r0, #0 - 1fa: f240 0100 movw r1, #0 - 1fe: f2c2 0000 movt r0, #8192 ; 0x2000 - 202: f2c2 0100 movt r1, #8192 ; 0x2000 - 206: 4281 cmp r1, r0 - 208: d21c bcs.n 244 - 20a: f240 2180 movw r1, #640 ; 0x280 - 20e: f240 0200 movw r2, #0 - 212: f2c0 0100 movt r1, #0 - 216: f2c2 0200 movt r2, #8192 ; 0x2000 - 21a: 680b ldr r3, [r1, #0] - 21c: f842 3b04 str.w r3, [r2], #4 - 220: 4282 cmp r2, r0 - 222: d20f bcs.n 244 - 224: 684b ldr r3, [r1, #4] - 226: f842 3b04 str.w r3, [r2], #4 - 22a: 4282 cmp r2, r0 - 22c: bf3e ittt cc - 22e: 688b ldrcc r3, [r1, #8] - 230: f842 3b04 strcc.w r3, [r2], #4 - 234: 4282 cmpcc r2, r0 - 236: d205 bcs.n 244 - 238: 68cb ldr r3, [r1, #12] - 23a: 3110 adds r1, #16 - 23c: f842 3b04 str.w r3, [r2], #4 - 240: 4282 cmp r2, r0 - 242: d3ea bcc.n 21a - 244: f7ff ff90 bl 168
- 248: defe udf #254 ; 0xfe + 1dc: d3ef bcc.n 1be + 1de: f240 0000 movw r0, #0 + 1e2: f240 0100 movw r1, #0 + 1e6: f2c2 0000 movt r0, #8192 ; 0x2000 + 1ea: f2c2 0100 movt r1, #8192 ; 0x2000 + 1ee: 4281 cmp r1, r0 + 1f0: d21c bcs.n 22c + 1f2: f240 2150 movw r1, #592 ; 0x250 + 1f6: f240 0200 movw r2, #0 + 1fa: f2c0 0100 movt r1, #0 + 1fe: f2c2 0200 movt r2, #8192 ; 0x2000 + 202: 680b ldr r3, [r1, #0] + 204: f842 3b04 str.w r3, [r2], #4 + 208: 4282 cmp r2, r0 + 20a: d20f bcs.n 22c + 20c: 684b ldr r3, [r1, #4] + 20e: f842 3b04 str.w r3, [r2], #4 + 212: 4282 cmp r2, r0 + 214: bf3e ittt cc + 216: 688b ldrcc r3, [r1, #8] + 218: f842 3b04 strcc.w r3, [r2], #4 + 21c: 4282 cmpcc r2, r0 + 21e: d205 bcs.n 22c + 220: 68cb ldr r3, [r1, #12] + 222: 3110 adds r1, #16 + 224: f842 3b04 str.w r3, [r2], #4 + 228: 4282 cmp r2, r0 + 22a: d3ea bcc.n 202 + 22c: f7ff ff93 bl 156
+ 230: defe udf #254 ; 0xfe -0000024a : - 24a: Address 0x000000000000024a is out of bounds. +00000232 : + 232: Address 0x0000000000000232 is out of bounds. -0000024b : - 24b: Address 0x000000000000024b is out of bounds. +00000233 : + 233: Address 0x0000000000000233 is out of bounds. -0000024c : - 24c: Address 0x000000000000024c is out of bounds. +00000234 : + 234: Address 0x0000000000000234 is out of bounds. -0000024d <__pre_init>: - 24d: Address 0x000000000000024d is out of bounds. +00000235 <__pre_init>: + 235: Address 0x0000000000000235 is out of bounds. -0000024e <__syscall>: - 24e: beab bkpt 0x00ab - 250: 4770 bx lr +00000236 <__syscall>: + 236: beab bkpt 0x00ab + 238: 4770 bx lr -00000252 <__cpsid>: - 252: b672 cpsid i - 254: 4770 bx lr +0000023a : + 23a: 4670 mov r0, lr + 23c: 2104 movs r1, #4 + 23e: 4208 tst r0, r1 + 240: d102 bne.n 248 + 242: f3ef 8008 mrs r0, MSP + 246: e002 b.n 24e + 248: f3ef 8009 mrs r0, PSP + 24c: e7ff b.n 24e -00000256 <__cpsie>: - 256: b662 cpsie i - 258: 4770 bx lr - -0000025a <__wfi>: - 25a: bf30 wfi - 25c: 4770 bx lr - -0000025e <__basepri_r>: - 25e: f3ef 8011 mrs r0, BASEPRI - 262: 4770 bx lr - -00000264 <__basepri_w>: - 264: f380 8811 msr BASEPRI, r0 - 268: 4770 bx lr - -0000026a : - 26a: 4670 mov r0, lr - 26c: 2104 movs r1, #4 - 26e: 4208 tst r0, r1 - 270: d102 bne.n 278 - 272: f3ef 8008 mrs r0, MSP - 276: e002 b.n 27e - 278: f3ef 8009 mrs r0, PSP - 27c: e7ff b.n 27e - -0000027e : - 27e: Address 0x000000000000027e is out of bounds. +0000024e : + 24e: Address 0x000000000000024e is out of bounds. -0000027f : - 27f: Address 0x000000000000027f is out of bounds. +0000024f : + 24f: Address 0x000000000000024f is out of bounds.