Assignment 7 - SGX Hands-on/src/enclave/enclave.c

@@ -150,15 +150,12 @@ sgx_status_t get_public_key(const uint8_t *sealed, uint32_t sealed_size, uint8_t
     return status;
 }
 
-sgx_status_t sign_firmware(const uint8_t *sealed, size_t sealed_size, uint8_t *data, size_t data_size, uint8_t *signature, size_t signature_size) {
+sgx_status_t sign_firmware(const uint8_t *data, uint32_t data_size, uint8_t *sealed, uint32_t sealed_size, uint8_t *signature, uint32_t signature_size) {
-    // handle missing sealed buffer
+    // invalid parameter handling
-    if((sealed == NULL) || (sealed_size == 0)) {
-        return SGX_ERROR_UNEXPECTED;
-    }
-    
-    // handle missing firmware buffer
     if((data == NULL) || (data_size == 0)) {
-        return SGX_ERROR_UNEXPECTED;
+        return SGX_ERROR_INVALID_PARAMETER;
+    } else if((sealed == NULL) || (sealed_size == 0)) {
+        return SGX_ERROR_INVALID_PARAMETER;
     }
     
     // declare need structures
@@ -174,7 +171,7 @@ sgx_status_t sign_firmware(const uint8_t *sealed, size_t sealed_size, uint8_t *d
 
     // try unseal keypair
     sgx_status_t seal_status;
-    if(seal_status = unseal_key_pair(sealed, &sealed_size, &private, NULL) != SGX_SUCCESS) {
+    if(seal_status = unseal_key_pair(sealed, &private, NULL) != SGX_SUCCESS) {
         if((status = sgx_ecc256_create_key_pair(&private, &public, ecc_handle)) != SGX_SUCCESS) {
             sgx_ecc256_close_context(ecc_handle);
             return status;
@@ -188,18 +185,17 @@ sgx_status_t sign_firmware(const uint8_t *sealed, size_t sealed_size, uint8_t *d
         return status;
     }
 
+    // TODO: possible wrong endianess for other programms
     // copy signature to return buffer
-    // TODO: endian swap
     if((signature == NULL) || (signature_size == 0)) {
         sgx_ecc256_close_context(ecc_handle);
-        return SGX_ERROR_UNEXPECTED;
+        return SGX_ERROR_INVALID_PARAMETER;
     }
-    memcpy(signature, ecc_signature.x, SGX_ECP256_KEY_SIZE);
+    memcpy(signature, ecc_signature.x, SI_SIZE);
-    memcpy(signature + SGX_ECP256_KEY_SIZE, ecc_signature.y, SGX_ECP256_KEY_SIZE);
 
-    if(seal_status != SGX_SUCCESS) {
+    // seal the key
-        seal_status = seal_key_pair(&private, &public, sealed, &sealed_size);
+    if((seal_status != SGX_SUCCESS) && (sealed != NULL)) {
-        // TODO: return sealed keypair
+        seal_status = seal_key_pair(&private, &public, &sealed, sealed_size);
     }
 
     // close ecc handle and return success

Assignment 7 - SGX Hands-on/src/enclave/enclave.edl

@@ -45,7 +45,7 @@ enclave {
         public int get_public_key_size();
         public int get_private_key_size();
         public sgx_status_t get_public_key([in, size=sealed_size]const uint8_t *sealed, uint32_t sealed_size, [out, size=gx_size]uint8_t *gx, uint32_t gx_size, [out, size=gx_size]uint8_t *gy, uint32_t gy_size);
-        public sgx_status_t sign_firmware([in, size=data_size]const uint8_t *sealed, size_t sealed_size, [in, size=data_size]uint8_t *data, size_t data_size, [out, size=signature_size]uint8_t *signature, size_t signature_size);
+        public sgx_status_t sign_firmware([in, size=data_size]const uint8_t *data, uint32_t data_size, [in, out, size=sealed_size]uint8_t *sealed, uint32_t sealed_size, [out, size=signature_size]uint8_t *signature, uint32_t signature_size);
     };
 
     /* 

Assignment 7 - SGX Hands-on/src/enclave/enclave.h

@@ -45,6 +45,6 @@ int get_public_key_size();
 int get_private_key_size();
 
 sgx_status_t get_public_key(const uint8_t *sealed, const uint32_t sealed_size, uint8_t *gx, uint32_t gx_size, uint8_t *gy, uint32_t gy_size);
-sgx_status_t sign_firmware(const uint8_t *sealed, size_t sealed_size, uint8_t *data, size_t data_size, uint8_t *signature, size_t signature_size);
+sgx_status_t sign_firmware(const uint8_t *data, uint32_t data_size, uint8_t *sealed, uint32_t sealed_size, uint8_t *signature, uint32_t signature_size);
 
 #endif /* !_ENCLAVE_H_ */